Skip to content

Test PR to check if dvc works#4462

Closed
seisman wants to merge 1 commit intoGenericMappingTools:mainfrom
seisman:check-dvc
Closed

Test PR to check if dvc works#4462
seisman wants to merge 1 commit intoGenericMappingTools:mainfrom
seisman:check-dvc

Conversation

@seisman
Copy link
Member

@seisman seisman commented Mar 21, 2026 •
edited
Loading

Verify if #4457 works.

@seisman seisman mentioned this pull request Mar 21, 2026
Merged
@weiji14
Copy link
Member

weiji14 commented Mar 22, 2026

We have duplicated DagsHub_Token in both repository-level and environment-level secrets. Maybe try deleting the repository-level one (in case the job is trying to use that) and see if it works?

@seisman
Copy link
Member Author

seisman commented Mar 23, 2026

Below are verbose messages from PR #4457:

2026-03-20 04:52:42,938 DEBUG: v3.67.0 (pip), CPython 3.12.3 on Linux-6.14.0-1017-azure-x86_64-with-glibc2.39
2026-03-20 04:52:42,939 DEBUG: command: /home/runner/work/pygmt/pygmt/.venv/bin/dvc pull --no-run-cache --verbose
2026-03-20 04:52:44,797 DEBUG: Preparing to transfer data from 'https://***@dagshub.com/GenericMappingTools/pygmt.dvc/files/md5' to '/home/runner/work/pygmt/pygmt/.dvc/cache/files/md5'
2026-03-20 04:52:44,797 DEBUG: Preparing to collect status from '/home/runner/work/pygmt/pygmt/.dvc/cache/files/md5'
2026-03-20 04:52:44,798 DEBUG: Collecting status from '/home/runner/work/pygmt/pygmt/.dvc/cache/files/md5'
2026-03-20 04:52:44,800 DEBUG: Preparing to collect status from 'https://***@dagshub.com/GenericMappingTools/pygmt.dvc/files/md5'

and below are messages from the current PR:

2026-03-21 04:05:29,389 DEBUG: v3.67.0 (pip), CPython 3.12.3 on Linux-6.14.0-1017-azure-x86_64-with-glibc2.39
2026-03-21 04:05:29,389 DEBUG: command: /home/runner/work/pygmt/pygmt/.venv/bin/dvc pull --no-run-cache --verbose
2026-03-21 04:05:31,245 DEBUG: Preparing to transfer data from 'https://@dagshub.com/GenericMappingTools/pygmt.dvc/files/md5' to '/home/runner/work/pygmt/pygmt/.dvc/cache/files/md5'
2026-03-21 04:05:31,245 DEBUG: Preparing to collect status from '/home/runner/work/pygmt/pygmt/.dvc/cache/files/md5'
2026-03-21 04:05:31,245 DEBUG: Collecting status from '/home/runner/work/pygmt/pygmt/.dvc/cache/files/md5'
2026-03-21 04:05:[31](https://github.com/GenericMappingTools/pygmt/actions/runs/23371611829/job/67996239467?pr=4462#step:8:32),247 DEBUG: Preparing to collect status from 'https://@dagshub.com/GenericMappingTools/pygmt.dvc/files/md5'
2026-03-21 04:05:31,247 DEBUG: Collecting status from 'https://@dagshub.com/GenericMappingTools/pygmt.dvc/files/md5'

There are not ***@dasghub in this PR, meaning the DAGSHUB_TOKEN env is empty.

@weiji14
Copy link
Member

weiji14 commented Mar 23, 2026

I'm re-reading the links in #4148:

The wording is not very clear, but it seems like the secret is still only available on pull_request_target triggers. I followed the blog post to https://github.com/executablebooks/github-activity/pull/134/changes, and there it does change the trigger from pull_request to pull_request_target.

Not sure if we want to change to pull_request_target (there might still be some security risk) for ci_tests.yml. The DVC cache seems to be working ok so far, and it doesn't hurt to keep #4457 I think. We could close this and continue the discussion in #4147?

@seisman seisman closed this Mar 24, 2026
@weiji14 weiji14 mentioned this pull request Mar 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman @weiji14